fix: is_valid_inputs in base.py #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now no longer requires typehints in the function signature (it wasn't using these anyway, and would break when they weren't included. Also, we now only check if mandatary arguments have been provided in input. None mandatory don't need to be present. Finally, addde a check to ensure that, if there are extra arguments provided in input not present in the signature, then these result in false being returned.
Siraj-Aizlewood
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 80.97% 81.07% +0.09%
==========================================
Files 45 44 -1
Lines 2676 2605 -71
==========================================
- Hits 2167 2112 -55
+ Misses 509 493 -16 ☔ View full report in Codecov by Sentry. |
jamescalam
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously couldn't handle cases where the dynamic route function didn't have argument type hints.
It was also too strict, ensuring that all arguments were provided, and not just the mandatory function arguments were provided.
Finally, added an additional check to ensure the LLM wasn't attempting to provide arguments that don't exist for the dynamic route function.