Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v0.0.46 #308

Merged
merged 1 commit into from
Jun 2, 2024
Merged

chore: release v0.0.46 #308

merged 1 commit into from
Jun 2, 2024

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented Jun 2, 2024

PR Type

other


Description

  • Bumped the version number from "0.0.45" to "0.0.46" in semantic_router/__init__.py.
  • Updated the version field in pyproject.toml to "0.0.46".

Changes walkthrough 📝

Relevant files
Miscellaneous
__init__.py
Bump version number in `__init__.py`                                         

semantic_router/init.py

  • Updated the __version__ attribute from "0.0.45" to "0.0.46".
+1/-1     
pyproject.toml
Update version in `pyproject.toml`                                             

pyproject.toml

  • Updated the version field from "0.0.45" to "0.0.46".
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@jamescalam jamescalam merged commit 89a94ea into main Jun 2, 2024
3 of 6 checks passed
@jamescalam jamescalam deleted the james/v0.0.46 branch June 2, 2024 13:01
@github-actions github-actions bot added the other label Jun 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

PR Description updated to latest commit (2556cb0)

Copy link

github-actions bot commented Jun 2, 2024

PR Review 🔍

⏱️ Estimated effort to review [1-5]

1, because the PR involves simple version number updates in two files, which is straightforward and requires minimal review effort.

🧪 Relevant tests

No

⚡ Possible issues

No

🔒 Security concerns

No

Code feedback:

Copy link

github-actions bot commented Jun 2, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Maintainability
Use a single source for version number to maintain consistency

Consider using a more robust method for managing version numbers, such as reading from a
single source like 'pyproject.toml'. This will help avoid inconsistencies and manual
errors in version updates across multiple files.

semantic_router/init.py [7]

-__version__ = "0.0.46"
+from importlib.metadata import version
+__version__ = version('semantic-router')
 
Suggestion importance[1-10]: 9

Why: This suggestion addresses a significant maintainability issue by proposing a method to avoid inconsistencies and manual errors in version updates across multiple files. It is highly relevant and improves the robustness of the code.

9
Best practice
Automate the version update process to reduce manual errors

Ensure that the version number is updated in a consistent and error-free manner by
potentially automating this process through CI/CD pipelines, using scripts that update all
necessary files simultaneously.

pyproject.toml [3]

-version = "0.0.46"
+version = "0.0.46"  # Consider automating this update
 
Suggestion importance[1-10]: 8

Why: Automating the version update process is a best practice that can significantly reduce the risk of manual errors. This suggestion is practical and enhances the reliability of the versioning process.

8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant