chore: Optimize Logging by Replacing f-Strings with Lazy Evaluation #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trings to improve performance through lazy evaluation
jamescalam
changed the title
|
hey @kaulson this is great, we were not aware of this — do you want to add the same enhancements elsewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
Refactor, enhancement
Description
This PR aims to enable lazy evaluation of the log messages.
I've replaced the f-strings inside the
loggercalls by printf-style string formatting to potentially improve performance a bit. I'm not sure if this is desired here, hence I only applied it for therolling_window.pythat I was reading through.For further reference see the pylint docs on this issue.