Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support check migration command #23

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Support check migration command #23

merged 5 commits into from
Jul 4, 2024

Conversation

olga24912
Copy link
Contributor

  • Separated the check migration
  • Fixed argument parsing for combine-indexed-and-state-data.
  • Updated migration-tool to the latest versions of aurora and aurora-eth-connector.
  • Fixed test data.

Current unresolved issue:

  • Previously, our migration fit into a single block. Now, the migration includes several callbacks. During the migration, we only check that the first command executed successfully without waiting for all the callbacks to complete. Therefore, during the migration check, the data might be outdated simply because not all transactions have completed yet.

@olga24912 olga24912 requested review from mrLSD and karim-en May 28, 2024 08:13
@karim-en karim-en merged commit 6231337 into master Jul 4, 2024
3 checks passed
@karim-en karim-en deleted the check_migration_args branch July 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karim-en karim-en karim-en approved these changes

@mrLSD mrLSD Awaiting requested review from mrLSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olga24912 @karim-en