Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Blockhash definition #213

Merged
merged 3 commits into from Aug 4, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Expand Up @@ -18,7 +18,7 @@
artifacts/
cache/
node_modules/
res/
etc/eth-contracts/res/

# Other
etc/state-migration-test/target/
Expand Down
46 changes: 44 additions & 2 deletions src/engine.rs
Expand Up @@ -20,6 +20,10 @@ use crate::state::AuroraStackState;
use crate::storage::{address_to_key, bytes_to_key, storage_to_key, KeyPrefix, KeyPrefixU8};
use crate::types::{u256_to_arr, AccountId, Wei, ERC20_MINT_SELECTOR};

/// Used as the first byte in the concatenation of data used to compute the blockhash.
/// Could be useful in the future as a version byte, or to distinguish different types of blocks.
const BLOCK_HASH_PREFIX: u8 = 0;

#[cfg(not(feature = "contract"))]
pub fn current_address() -> Address {
crate::types::near_account_to_evm_address("engine".as_bytes())
Expand Down Expand Up @@ -191,7 +195,7 @@ impl AsRef<[u8]> for EngineStateError {
/// Should not contain anything large or enumerable.
#[derive(BorshSerialize, BorshDeserialize, Default)]
pub struct EngineState {
/// Chain id, according to the EIP-115 / ethereum-lists spec.
/// Chain id, according to the EIP-155 / ethereum-lists spec.
pub chain_id: [u8; 32],
/// Account which can upgrade this contract.
/// Use empty to disable updatability.
Expand Down Expand Up @@ -245,6 +249,36 @@ impl Engine {
);
}

/// There is one Aurora block per NEAR block height (note: when heights in NEAR are skipped
/// they are interpreted as empty blocks on Aurora). The blockhash is derived from the height
/// according to
/// ```text
/// block_hash = sha256(concat(
/// BLOCK_HASH_PREFIX,
/// block_height as u64,
/// chain_id,
/// engine_account_id,
/// ))
/// ```
pub fn compute_block_hash(chain_id: [u8; 32], block_height: u64, account_id: &[u8]) -> H256 {
let mut data = Vec::with_capacity(1 + 8 + 32 + account_id.len());
birchmd marked this conversation as resolved.
Show resolved Hide resolved
data.push(BLOCK_HASH_PREFIX);
data.extend_from_slice(&block_height.to_be_bytes());
data.extend_from_slice(&chain_id);
data.extend_from_slice(account_id);

#[cfg(not(feature = "contract"))]
{
use sha2::Digest;

let output = sha2::Sha256::digest(&data);
H256(output.into())
}

#[cfg(feature = "contract")]
sdk::sha256(&data)
}

/// Fails if state is not found.
pub fn get_state() -> Result<EngineState, EngineStateError> {
match sdk::read_storage(&bytes_to_key(KeyPrefix::Config, STATE_KEY)) {
Expand Down Expand Up @@ -705,7 +739,15 @@ impl evm::backend::Backend for Engine {
fn block_hash(&self, number: U256) -> H256 {
let idx = U256::from(sdk::block_index());
if idx.saturating_sub(U256::from(256)) <= number && number < idx {
H256::from([255u8; 32])
// since `idx` comes from `u64` it is always safe to downcast `number` from `U256`
#[cfg(feature = "contract")]
{
let account_id = sdk::current_account_id();
Self::compute_block_hash(self.state.chain_id, number.low_u64(), &account_id)
}

#[cfg(not(feature = "contract"))]
Self::compute_block_hash(self.state.chain_id, number.low_u64(), b"aurora")
} else {
H256::zero()
}
Expand Down
39 changes: 38 additions & 1 deletion src/test_utils/solidity.rs
@@ -1,4 +1,5 @@
use crate::prelude::Address;
use crate::prelude::{Address, U256};
use crate::transaction::LegacyEthTransaction;
use near_sdk::serde_json;
use serde::Deserialize;
use std::fs;
Expand Down Expand Up @@ -73,6 +74,42 @@ impl ContractConstructor {
address,
}
}

pub fn deploy_without_args(&self, nonce: U256) -> LegacyEthTransaction {
let data = self
.abi
.constructor()
.unwrap()
.encode_input(self.code.clone(), &[])
.unwrap();
LegacyEthTransaction {
nonce,
gas_price: Default::default(),
gas: u64::MAX.into(),
to: None,
value: Default::default(),
data,
}
}
}

impl DeployedContract {
pub fn call_method_without_args(&self, method_name: &str, nonce: U256) -> LegacyEthTransaction {
let data = self
.abi
.function(method_name)
.unwrap()
.encode_input(&[])
.unwrap();
LegacyEthTransaction {
nonce,
gas_price: Default::default(),
gas: u64::MAX.into(),
to: Some(self.address),
value: Default::default(),
data,
}
}
}

/// Compiles a solidity contract. `source_path` gives the directory containing all solidity
Expand Down
32 changes: 2 additions & 30 deletions src/test_utils/standard_precompiles.rs
Expand Up @@ -24,21 +24,7 @@ impl PrecompilesConstructor {
}

pub fn deploy(&self, nonce: U256) -> LegacyEthTransaction {
let data = self
.0
.abi
.constructor()
.unwrap()
.encode_input(self.0.code.clone(), &[])
.unwrap();
LegacyEthTransaction {
nonce,
gas_price: Default::default(),
gas: u64::MAX.into(),
to: None,
value: Default::default(),
data,
}
self.0.deploy_without_args(nonce)
}

fn solidity_artifacts_path() -> PathBuf {
Expand All @@ -52,21 +38,7 @@ impl PrecompilesConstructor {

impl PrecompilesContract {
pub fn call_method(&self, method_name: &str, nonce: U256) -> LegacyEthTransaction {
let data = self
.0
.abi
.function(method_name)
.unwrap()
.encode_input(&[])
.unwrap();
LegacyEthTransaction {
nonce,
gas_price: Default::default(),
gas: u64::MAX.into(),
to: Some(self.0.address),
value: Default::default(),
data,
}
self.0.call_method_without_args(method_name, nonce)
}

pub fn all_method_names() -> &'static [&'static str] {
Expand Down
13 changes: 13 additions & 0 deletions src/tests/res/blockhash.sol
@@ -0,0 +1,13 @@
// SPDX-License-Identifier: Unlicense
pragma solidity ^0.8.0;

contract BlockHash {
constructor() payable {}

function test() public view {
require(
blockhash(0) == hex"a7ac0e4bd5ad1654392b64ecd40a69f983e8ce7c315639a339d19a880902457a",
"Bad block hash"
);
}
}
44 changes: 44 additions & 0 deletions src/tests/sanity.rs
Expand Up @@ -2,6 +2,7 @@ use crate::prelude::Address;
use crate::test_utils;
use crate::types::{Wei, ERC20_MINT_SELECTOR};
use secp256k1::SecretKey;
use std::path::{Path, PathBuf};

const INITIAL_BALANCE: Wei = Wei::new_u64(1000);
const INITIAL_NONCE: u64 = 0;
Expand Down Expand Up @@ -178,3 +179,46 @@ fn check_selector() {
hasher.update(b"mint(address,uint256)");
assert_eq!(hasher.finalize()[..4].to_vec(), ERC20_MINT_SELECTOR);
}

#[test]
fn test_block_hash() {
let runner = test_utils::AuroraRunner::default();
let chain_id = {
let number = crate::prelude::U256::from(runner.chain_id);
crate::types::u256_to_arr(&number)
};
let account_id = runner.aurora_account_id;
let block_hash = crate::engine::Engine::compute_block_hash(chain_id, 10, account_id.as_bytes());

assert_eq!(
hex::encode(block_hash.0).as_str(),
"4c8a60b32b74f184438a5e450951570bc1bda37caa7b6a3f178b80395845fb80"
);
}

#[test]
fn test_block_hash_contract() {
let (mut runner, mut source_account, _) = initialize_transfer();
let test_constructor = test_utils::solidity::ContractConstructor::compile_from_source(
["src", "tests", "res"].iter().collect::<PathBuf>(),
Path::new("target").join("solidity_build"),
"blockhash.sol",
"BlockHash",
);
let nonce = source_account.use_nonce();
let test_contract = runner.deploy_contract(
&source_account.secret_key,
|c| c.deploy_without_args(nonce.into()),
test_constructor,
);

let result = runner
.submit_with_signer(&mut source_account, |nonce| {
test_contract.call_method_without_args("test", nonce)
})
.unwrap();

if !result.status {
panic!("{}", String::from_utf8_lossy(&result.result));
}
}