Feat(engine): log storage writes from applying transactions #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added a commit
that referenced
this pull request
Nov 1, 2021
birchmd
added a commit
that referenced
this pull request
Nov 1, 2021
birchmd
force-pushed
the
logging-storage-writes
branch
from
405bbb4
to
c226495
Compare
birchmd
added a commit
that referenced
this pull request
Nov 1, 2021
birchmd
force-pushed
the
logging-storage-writes
branch
from
c226495
to
e4fce3d
Compare
joshuajbouw
approved these changes
Nov 1, 2021
engine/src/engine.rs
Outdated
Comment on lines
1060
to
1062
| "Address {:?} set code with {} bytes", | ||
| address, | ||
| code_bytes_written, |
There was a problem hiding this comment.
Should be written as two logs such as:
written_bytes <address> <code_bytes_writte that was its easier for a tool to parse.
engine/src/engine.rs
Outdated
Comment on lines
1111
to
1114
| sdk::log!( | ||
| crate::prelude::format!("Total number of storage writes: {}", writes_counter).as_str() | ||
| ); | ||
| sdk::log!(crate::prelude::format!("Total bytes written: {}", total_bytes).as_str()); |
birchmd
added a commit
that referenced
this pull request
Nov 1, 2021
Merged
artob
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.