ETH connector #59
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| CARGO = cargo | ||
| NEAR = near | ||
| FEATURES = contract,log | ||
|
|
||
| ifeq ($(evm-bully),yes) | ||
| FEATURES := $(FEATURES),evm_bully | ||
|
|
@@ -15,6 +15,7 @@ release.wasm: target/wasm32-unknown-unknown/release/aurora_engine.wasm | |
|
|
||
| target/wasm32-unknown-unknown/release/aurora_engine.wasm: Cargo.toml Cargo.lock $(wildcard src/*.rs) | ||
| RUSTFLAGS='-C link-arg=-s' $(CARGO) build --target wasm32-unknown-unknown --release --no-default-features --features=$(FEATURES) -Z avoid-dev-deps | ||
| ls -l target/wasm32-unknown-unknown/release/aurora_engine.wasm | ||
|
|
||
| debug: debug.wasm | ||
|
|
||
|
|
@@ -24,6 +25,11 @@ debug.wasm: target/wasm32-unknown-unknown/debug/aurora_engine.wasm | |
| target/wasm32-unknown-unknown/debug/aurora_engine.wasm: Cargo.toml Cargo.lock $(wildcard src/*.rs) | ||
| $(CARGO) build --target wasm32-unknown-unknown --no-default-features --features=$(FEATURES) -Z avoid-dev-deps | ||
|
|
||
| test-build: | ||
| RUSTFLAGS='-C link-arg=-s' $(CARGO) build --target wasm32-unknown-unknown --release --no-default-features --features=contract,integration-test -Z avoid-dev-deps | ||
| ln -sf target/wasm32-unknown-unknown/release/aurora_engine.wasm release.wasm | ||
| ls -l target/wasm32-unknown-unknown/release/aurora_engine.wasm | ||
|
|
||
| .PHONY: all release debug | ||
|
|
||
| deploy: release.wasm | ||
|
|
@@ -35,10 +41,10 @@ check-format: | |
| $(CARGO) fmt -- --check | ||
|
|
||
| check-clippy: | ||
| $(CARGO) clippy --no-default-features --features=$(FEATURES) -- -D warnings | ||
|
Comment on lines
-38
to
+44
There was a problem hiding this comment. 👍 |
||
|
|
||
| # test depends on release since `tests/test_upgrade.rs` includes `release.wasm` | ||
| test: test-build | ||
| $(CARGO) test | ||
|
|
||
| format: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # ETH connector | ||
|
|
||
| ## Build | ||
| 1. For production set in the Makefile | ||
| ``` | ||
| FEATURES = contract | ||
| ``` | ||
| 1.1. For **development and testing** set in the Makefile | ||
| ``` | ||
| FEATURES = contract,integration-test | ||
| ``` | ||
| 2. Build release: `$ make release` | ||
| 3. Run tests: `$ cargo test` | ||
| 4. Deploying process is common for Aurora itself. Please reference [README.md](../README.md) | ||
|
|
||
| ## Initialize eth-conenctor | ||
| With `near-cli` run: | ||
| ``` | ||
| $ near call <NEAR_ACC> new_eth_connector '{"prover_account": "<PROVER_NEAR_ACCOUNT>", "eth_custodian_address": "<ETH_ADDRESS>"}' --account-id <NEAR_ACC> | ||
|
|
||
| ``` | ||
|
|
||
| ## ETH connector specific methods | ||
| * new_eth_connector (call once) | ||
| * deposit (mutable) | ||
| * withdraw (mutable, payable) | ||
| * finish_deposit_near (private, mutable) | ||
| * ft_total_supply (view) | ||
| * ft_total_supply_near (view) | ||
| * ft_total_supply_eth (view) | ||
| * ft_balance_of (view) | ||
| * ft_balance_of_eth (view) | ||
| * ft_transfer (mutable, payable) | ||
| * ft_resolve_transfer (private, mutable) | ||
| * ft_transfer_call (mutable, payable) | ||
| * ft_on_transfer (private, mutable) | ||
| * storage_deposit (mutable) | ||
| * storage_withdraw (mutable, payable) | ||
| * storage_balance_of (view) | ||
|
|
||
| ## Ethereum specific flow | ||
| Follow by [this instruction](https://github.com/aurora-is-near/eth-connector/blob/master/README.md). |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be on by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a discussion about this on Slack.
Summary is: if something goes wrong in production there's basically no way to know what happened without logging and it's not that expensive to have it (@mrLSD measured it to be ~0.5 Tgas which is much much less than any operation currently).