Fix: remove unused state variable bridge_prover_id
#749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
requested review from
RomanHodulak,
aleksuss and
joshuajbouw
as code owners
|
I'm really curious about the changes in the |
I didn't dig into it further because there were quite a few changes. I just reverted the whole file back to the version on |
aleksuss
approved these changes
May 5, 2023
0x3bfc
reviewed
May 8, 2023
0x3bfc
approved these changes
May 8, 2023
birchmd
force-pushed
the
fix/birchmd/audit-aur-30
branch
from
b361906
to
b1015b0
Compare
aleksuss
approved these changes
May 11, 2023
joshuajbouw
approved these changes
May 11, 2023
Merged
birchmd
added a commit
that referenced
this pull request
May 11, 2023
This PR is a modified version of #726 Normally I would not make a whole separate PR, but I ended up starting this work from scratch off of `develop` because I could not understand why the gas costs in `repro` were increased so much in the old PR. I have since figured out that it was some change in `Cargo.lock` that was causing the problem, but by that point I already had all this code finished in a separate branch so I thought it would be easier to make a separate PR at that point. Key differences from #726 : 1. The `repro` tests pass without any changes to the gas values (i.e. this implementation does not create a significant gas increase). This is mostly due to leaving `Cargo.lock` untouched, but there are a few other improvements as well (see below). 2. Automatically migrate the state if the V1 state is found. This change means that after the first transaction, the fallback deserialization logic will not be executed and hence reading the state will be as efficient as it always was (as exemplified by the `repro` gas costs remaining unchanged). 3. Use `Cow` in `BorshableEngineState` so that `From<&EngineState> for BorshableEngineState` does not need to clone the owner account id. 4. Ensure removing the `bridge_prover_id` field from `NewCallArgs` is done in a backwards compatible way. This is not a performance improvement, but it is still a critical change. We must ensure that changes to the format of top-level contract functions are always backwards compatible otherwise the Borealis Engine and Borealis Refiner will not be able to parse old transactions (it will fail to deserialize the arguments).
joshuajbouw
added a commit
that referenced
this pull request
May 15, 2023
## 2.9.1 2023-05-11 ### Changes - Removed unused state variable `bridge_prover_id` by @birchmd. (#749) - `modexp` has been improved to be greatly faster than before by @birchmd. (#757) ### Fixes - Fixed an issue where the owner could call `new` multiple times by @lempire123. (#733) - Fixed an issue with `deploy_upgrade` where the upgrade index isn't cleared by @lempire123. (#741) --------- Co-authored-by: lempire123 <61431140+lempire123@users.noreply.github.com> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev>
mrLSD
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a modified version of #726
Normally I would not make a whole separate PR, but I ended up starting this work from scratch off of
developbecause I could not understand why the gas costs inreprowere increased so much in the old PR. I have since figured out that it was some change inCargo.lockthat was causing the problem, but by that point I already had all this code finished in a separate branch so I thought it would be easier to make a separate PR at that point.Key differences from #726 :
reprotests pass without any changes to the gas values (i.e. this implementation does not create a significant gas increase). This is mostly due to leavingCargo.lockuntouched, but there are a few other improvements as well (see below).reprogas costs remaining unchanged).CowinBorshableEngineStateso thatFrom<&EngineState> for BorshableEngineStatedoes not need to clone the owner account id.bridge_prover_idfield fromNewCallArgsis done in a backwards compatible way. This is not a performance improvement, but it is still a critical change. We must ensure that changes to the format of top-level contract functions are always backwards compatible otherwise the Borealis Engine and Borealis Refiner will not be able to parse old transactions (it will fail to deserialize the arguments).