Fix(modexp): properly handle the case where the exponent is zero #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-bug
aleksuss
approved these changes
Jun 7, 2023
birchmd
added a commit
that referenced
this pull request
Jun 22, 2023
## Description We need to specially handle the case where the exponent is zero because the main code does not do this correctly. Note: EVM treats 0^0 as equal to 1. ## Testing New test for this case.
mrLSD
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to specially handle the case where the exponent is zero because the main code does not do this correctly. Note: EVM treats 0^0 as equal to 1.
Testing
New test for this case.