feat: relayer function call keys #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # engine-tests/Cargo.toml
# Conflicts: # Cargo.lock # engine-tests/src/utils/standalone/mod.rs # engine-workspace/src/account.rs # engine-workspace/src/contract.rs # engine-workspace/src/lib.rs # engine-workspace/src/node.rs # engine-workspace/src/operation.rs # etc/xcc-router/Cargo.lock
mrLSD
approved these changes
Jul 18, 2023
vimpunk
reviewed
Jul 18, 2023
joshuajbouw
approved these changes
Jul 18, 2023
joshuajbouw
added a commit
that referenced
this pull request
Jul 21, 2023
The PR adds new types of transactions for adding and removing functional keys used by our relayer. High-level requirements: - The keys could be added/removed by a specific account with access granted by the owner. - The list of allowing functions to invoke: `submit`, `submit_with_args`, `call`. - The added key can call the contract via which the key has been added ( receiver_id == io.current_id() on step 1 ). - The key has allowance equals attached NEAR on the adding stage. - The key should be verified at the removal stage to correspond to the 2 and 3 requirements. There are no changes in performance. Added integration tests. !!! **The base branch should be changed to `develop` after merging Also, these changes along with changes from #779 require updating borealis-engine. cc @mandreyel.
Merged
joshuajbouw
added a commit
that referenced
this pull request
Jul 21, 2023
The PR adds new types of transactions for adding and removing functional keys used by our relayer. High-level requirements: - The keys could be added/removed by a specific account with access granted by the owner. - The list of allowing functions to invoke: `submit`, `submit_with_args`, `call`. - The added key can call the contract via which the key has been added ( receiver_id == io.current_id() on step 1 ). - The key has allowance equals attached NEAR on the adding stage. - The key should be verified at the removal stage to correspond to the 2 and 3 requirements. There are no changes in performance. Added integration tests. !!! **The base branch should be changed to `develop` after merging Also, these changes along with changes from #779 require updating borealis-engine. cc @mandreyel.
joshuajbouw
added a commit
that referenced
this pull request
Jul 21, 2023
The PR adds new types of transactions for adding and removing functional keys used by our relayer. High-level requirements: - The keys could be added/removed by a specific account with access granted by the owner. - The list of allowing functions to invoke: `submit`, `submit_with_args`, `call`. - The added key can call the contract via which the key has been added ( receiver_id == io.current_id() on step 1 ). - The key has allowance equals attached NEAR on the adding stage. - The key should be verified at the removal stage to correspond to the 2 and 3 requirements. There are no changes in performance. Added integration tests. !!! **The base branch should be changed to `develop` after merging Also, these changes along with changes from #779 require updating borealis-engine. cc @mandreyel.
joshuajbouw
pushed a commit
that referenced
this pull request
Jul 24, 2023
joshuajbouw
added a commit
that referenced
this pull request
Jul 24, 2023
### Changes - Enabled Shanghai Ethereum hard fork support by @mandreyel. #773 - Added ability to pause and resume the core functionality of the contract by @Casuso. #779 - Added function call keys to be used with relayers by @aleksuss. #792 --------- Co-authored-by: mandreyel <mandreyel@aurora.dev> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Leandro Casuso Montero <leandro.montero@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds new types of transactions for adding and removing functional keys used by our relayer.
High-level requirements:
submit,submit_with_args,call.Performance / NEAR gas cost considerations
There are no changes in performance.
Testing
Added integration tests.
Additional information
!!! The base branch should be changed to
developafter merging #777 !!!Also, these changes along with changes from #779 require updating borealis-engine.
cc @mandreyel.