feat: possibility to set metadata for erc20 contracts #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
force-pushed
the
feat/aleksuss/set_erc20_metadata
branch
from
8321d0f
to
ab6fa78
Compare
birchmd
reviewed
Sep 12, 2023
aleksuss
force-pushed
the
feat/aleksuss/set_erc20_metadata
branch
from
be5a5b6
to
61dbd5a
Compare
|
One bad moment of changing borsh to JSON is that it increases the number of functions and size of the smart contract. |
|
Increasing the number of functions is ok in my opinion. The reason for counting them is because there is a hard limit on the number of functions Near allows in a contract. But this limit is 10000, so we are not close to exceeding it. How much bigger is the contract size? Will it be offset by the wasm opt improvment? |
|
birchmd
approved these changes
Sep 13, 2023
mrLSD
approved these changes
Sep 13, 2023
aleksuss
added a commit
that referenced
this pull request
Sep 25, 2023
## Description The PR adds functions for setting (`set_erc20_metadata`) and getting (`get_erc20_metadata`) metadata of ERC-20 contracts deployed with `deploy_erc20_token` transaction. ## Performance / NEAR gas cost considerations There are no performance changes. ## Testing The corresponding test has been added. ## Additional information Probably, there should be a new role for `set_erc20_metadata` transaction. I guess it should be added in a new PR.
Merged
aleksuss
added a commit
that referenced
this pull request
Sep 25, 2023
- Added the possibility to use native NEAR instead of wNEAR on Aurora by [@karim-en]. ([#750]) - Added hashchain integration by [@birchmd]. ([#831]) - Added functions for setting and getting metadata of ERC-20 contracts deployed with `deploy_erc20_token` transaction by [@aleksuss]. ([#837]) --------- Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Karim <karim@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds functions for setting (
set_erc20_metadata) and getting (get_erc20_metadata) metadata of ERC-20 contracts deployed withdeploy_erc20_tokentransaction.Performance / NEAR gas cost considerations
There are no performance changes.
Testing
The corresponding test has been added.
Additional information
Probably, there should be a new role for
set_erc20_metadatatransaction. I guess it should be added in a new PR.