Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the logic of gas cost calculation in silo mode #854

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

aleksuss
Copy link
Member

Description

The PR changes the logic of gas calculation in Silo mode. Fixed gas cost has been replaced with a fixed amount of gas per transaction.

Performance / NEAR gas cost considerations

There are no changes related to performance.

Testing

Corresponding tests have been added.

engine-types/src/types/wei.rs Outdated Show resolved Hide resolved
engine/src/engine.rs Outdated Show resolved Hide resolved
engine/src/engine.rs Outdated Show resolved Hide resolved
@aleksuss aleksuss requested a review from birchmd October 23, 2023 14:48
engine-types/src/types/wei.rs Show resolved Hide resolved
engine-tests/src/tests/silo.rs Show resolved Hide resolved
@aleksuss aleksuss added this pull request to the merge queue Oct 23, 2023
Merged via the queue into develop with commit c82d1b7 Oct 23, 2023
24 checks passed
@aleksuss aleksuss deleted the feat/aleksuss/silo_logic branch October 23, 2023 15:39
aleksuss added a commit that referenced this pull request Oct 23, 2023
## Description

The PR changes the logic of gas calculation in Silo mode. Fixed gas cost
has been replaced with a fixed amount of gas per transaction.

## Performance / NEAR gas cost considerations

There are no changes related to performance.

## Testing

Corresponding tests have been added.
@aleksuss aleksuss mentioned this pull request Oct 23, 2023
aleksuss added a commit that referenced this pull request Oct 24, 2023
## Release 3.3.0

### Changes

- Changed the logic of cost calculation in Silo mode. Specifically, the
fixed cost has been replaced with
  a fixed amount of gas per transaction by [@aleksuss]. ([#854]) 

- `near-workspaces-rs` has been updated to 0.8.0 by [@aleksuss].
([#855])

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants