Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments from Audit #86

Merged
merged 6 commits into from May 18, 2021
Merged

Address comments from Audit #86

merged 6 commits into from May 18, 2021

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented May 13, 2021

Closes #76

Addresses most of the minor TODOs from #74
One still remains, but I'm unsure how to address it. I've reached out for clarification. That last one can be done as a separate PR.

@birchmd birchmd requested review from artob and joshuajbouw May 13, 2021 18:53
@birchmd birchmd added the C-enhancement Category: New feature or request label May 13, 2021
@artob artob self-assigned this May 13, 2021
@artob artob added this to In progress in EVM on MainNet via automation May 13, 2021
sept-en
sept-en approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also, as you use constant for the REGISTER_ID in read_input_arr_20(), please do the same in read_input().

EVM on MainNet automation moved this from In progress to Reviewer approved May 14, 2021
@birchmd birchmd linked an issue May 17, 2021 that may be closed by this pull request
Remedy action items from #74 #76
Closed
@birchmd
Copy link
Member Author

birchmd commented May 18, 2021

Also, as you use constant for the REGISTER_ID in read_input_arr_20(), please do the same in read_input().

@sept-en done in 8ae6443

@artob artob merged commit 45c1e52 into develop May 18, 2021
@artob artob deleted the 76-address-audit-comments branch May 18, 2021 22:33
EVM on MainNet automation moved this from Reviewer approved to Done May 18, 2021
@birchmd birchmd mentioned this pull request May 21, 2021
Closed
sept-en added a commit that referenced this pull request May 28, 2021
@sept-en @artob
@birchmd @matklad
Eth-connector: merge develop branch (#109)
540ccb1 
* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Remove resolved TODOs

* Fix state migration test

* Conditional compilation minor improvements.

Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
mfornet added a commit that referenced this pull request Jun 4, 2021
@joshuajbouw @mfornet
@artob @birchmd @matklad @mrLSD
Implement generational storage (#87)
d67b59e 
* Base precompile code between connectors (#73)

* Base precompile code between connectors

* Handle errors and validate input

* Use proper result

* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Implement BC generational storage.

* fix address input

* remove note

* put key on the end of the storage key

* remove pub from methods

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Implement the ETH connector. (#59)

* Move when to call `set_generation`

* Fix arg

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>
mfornet added a commit that referenced this pull request Jun 10, 2021
@mfornet @birchmd
@joshuajbouw @artob @matklad @mrLSD
Implement generational storage with SELFDESTRUCT tests (#84)
2bf9b25 
* Add tests for state check after selfdestruct

* Aurora runner tracks storage usage to avoid underflow when storage is released in future transactions (#85)

* Implement generational storage (#87)

* Base precompile code between connectors (#73)

* Base precompile code between connectors

* Handle errors and validate input

* Use proper result

* Document `aurora encode-address` usage.

* Cache cargo artifacts between CI runs. (#92)

* Address comments from audit. (#86)

* Validate register length in `read_input_arr20()`
* Only read register length in `Engine::get_code_size`
* Add `read_input_borsh()`
* Ensure `method.args.len() == args_decoded.len()`
* Ensure register size is 8 in `read_u64`
* Use constant to specify the register ID used in `read_input()`

* Reduce size of `cargo cache` in CI. (#95)

* Define a `Wei` newtype for balances. (#96)

* Fix evm-bully builds after recent refactoring. (#100)

* Refactor `Engine::get_state` to return a `Result`. (#99)

* Ensure that `Cargo.lock` in the repo is valid. (#101)

* Remove unneeded nightly feature. (#102)

* Implement BC generational storage.

* fix address input

* remove note

* put key on the end of the storage key

* remove pub from methods

* Dispatch precompiles on the full address. (#107)

* Support state migration on upgrade. (#103)

* Implement the ETH connector. (#59)

* Move when to call `set_generation`

* Fix arg

Co-authored-by: Marcelo Fornet <mfornet94@gmail.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>

* Fix layout of the key

* Fix all tests (don't wipe the storage all the time)

* Use correct generation in writing storage

* Remove unnecessary references

Co-authored-by: Michael Birch <michael@near.org>
Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Evgeny Ukhanov <mrlsd@ya.ru>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuajbouw joshuajbouw joshuajbouw left review comments

@artob artob artob approved these changes

@sept-en sept-en sept-en approved these changes

Assignees

@artob artob

@joshuajbouw joshuajbouw

Labels
C-enhancement Category: New feature or request
Projects
EVM on MainNet
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remedy action items from #74
4 participants
@birchmd @artob @sept-en @joshuajbouw