-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EthConnector: make AdminControlled and pausable #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me so far!
Btw, the CI is failing because of the internal Github Actions issue reported there. |
tests/test_connector.rs
Outdated
let promises = res.promise_results(); | ||
let p = promises[1].clone(); | ||
match p.unwrap().status() { | ||
ExecutionStatus::Failure(_) => {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's worth trying to check specifically the error is raised because of the pause (e.g. by checking the error message), as opposed to some other reason. Just for the sake of completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for me! It's worth adding the same for already existing tests there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change PausedMask
logic to enum
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed with @sept-en directly, so for now, the current implementation is pretty enough.
As we internally discussed with @joshuajbouw @birchmd, we won't use |
…ora-engine into admin-controlled-and-pausable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work!
No description provided.