Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

сhore: bump rust nightly to 2023-12-15 #885

Merged
merged 14 commits into from
Jan 18, 2024
Merged

сhore: bump rust nightly to 2023-12-15 #885

merged 14 commits into from
Jan 18, 2024

Conversation

RomanHodulak
Copy link
Contributor

Description

  • Upgrades rust version 1.70 => 1.76
  • Resolves all issues reported by clippy

Performance / NEAR gas cost considerations

Does not change.

Testing

The clippy run succeeded and reported no further issues.

How should this be reviewed

Check that the code changes are introduced in a proper code style.

Additional information

None

aleksuss
aleksuss reviewed Jan 2, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@aleksuss aleksuss marked this pull request as ready for review January 2, 2024 13:40
@aleksuss aleksuss changed the title Chore: Fix all clippy issues сhore: bump rust nightly to 2023-12-15 Jan 2, 2024
birchmd
birchmd requested changes Jan 8, 2024
View reviewed changes
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to MockedExternalWithTrie::get_trie_nodes_count needs to be reverted because otherwise we are missing out on a large part of the gas cost.

engine-tests/src/tests/modexp.rs Show resolved Hide resolved
engine-tests/src/tests/promise_results_precompile.rs Outdated Show resolved Hide resolved
engine-tests/src/utils/mocked_external.rs Outdated Show resolved Hide resolved
engine-tests/src/tests/one_inch.rs Outdated Show resolved Hide resolved
engine-tests/src/tests/uniswap.rs Outdated Show resolved Hide resolved
engine-tests/src/tests/uniswap.rs Outdated Show resolved Hide resolved
engine-tests/src/tests/xcc.rs Show resolved Hide resolved
@aleksuss aleksuss mentioned this pull request Jan 10, 2024
Merged
@aleksuss aleksuss requested a review from birchmd January 18, 2024 14:47
birchmd
birchmd approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good me! Thanks for all the work upgrading the Near Runtime dependencies.

I'm a little worried that some gas costs went up with the new compiler version when I think all other rust version changes have lowered the gas costs. But I suppose there is nothing we can do about it.

engine-tests/src/tests/standard_precompiles.rs Show resolved Hide resolved
@aleksuss aleksuss added this pull request to the merge queue Jan 18, 2024
Merged via the queue into develop with commit 458d0b8 Jan 18, 2024
24 checks passed
@aleksuss aleksuss deleted the feat/romanhodulak/clippy branch January 18, 2024 19:36
aleksuss added a commit that referenced this pull request Feb 6, 2024
@RomanHodulak @aleksuss
сhore: bump rust nightly to 2023-12-15 (#885)
557f57d 
<!--
Thanks for submitting a pull request! Here are some helpful tips:

* Always create branches on and target the `develop` branch.
* Run all the tests locally and ensure that they are passing.
* Run `make format` to ensure that the code is formatted.
* Run `make check` to ensure that all checks passed successfully.
* Small commits and contributions that attempt one single goal is
preferable.
* If the idea changes or adds anything functional which will affect
users, an
AIP discussion is required first on the Aurora forum: 

https://forum.aurora.dev/discussions/AIPs%20(Aurora%20Improvement%20Proposals).
* Avoid breaking the public API (namely in engine/src/lib.rs) unless
required.
* If your PR is a WIP, ensure that you enable "draft" mode.
* Your first PRs won't use the CI automatically unless a maintainer
starts.
If this is not your first PR, please do NOT abuse the CI resources.

Checklist:
- [ ] I have performed a self-review of my code
- [ ] I have documented my code, particularly in the hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to prove my fix or new feature is effective and
works
- [ ] Any dependent changes have been merged
- [ ] The PR is targeting the `develop` branch and not `master`
- [ ] I have pre-squashed my commits into a single commit and rebased.
-->

## Description

* Upgrades rust version 1.70 => 1.76
* Resolves all issues reported by clippy
<!-- 
Provide a general summary of your changes. A clear overview along with
an
in-depth explanation is beneficial.

If this PR closes any issues, be sure to add "closes #<number>"
somewhere.
-->

## Performance / NEAR gas cost considerations

Does not change.
<!--
Performance regressions are not ideal, though we welcome performance 
improvements. Any PR must be completely mindful of any gas cost
increases. The
CI will fail if the gas costs change at all. Do update these tests to 
accommodate for the new gas changes. It is good to explain 
this change, if necessary.
-->

## Testing

The clippy run succeeded and reported no further issues.

<!--
Please describe the tests that you ran to verify your changes.
-->

## How should this be reviewed

Check that the code changes are introduced in a proper code style.
<!--
Include any recommendations of areas to be careful of to ensure that the
reviewers use extra attention.
-->

## Additional information

None
<!--
Include any additional information which you think should be in this PR,
such
as prior arts, future extensions, unresolved problems, or a TODO list
which
should be followed up.
-->

---------

Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
@aleksuss aleksuss mentioned this pull request Feb 6, 2024
Merged
aleksuss added a commit that referenced this pull request Feb 6, 2024
@aleksuss @guidovranken
@karim-en @RomanHodulak @birchmd @dependabot
Release 3.6.0 (#895)
7029a5c 
## 3.6.0 2024-02-06

### Fixes

- Fixed underflow in the modexp gas calculation by [@guidovranken].
([#883])
- Prevented subtraction underflow in th xcc module by [@guidovranken].
([#888])
- Fixed balance and gas overflows in the xcc module by [@guidovranken].
([#889])

### Changes

- CI was updated by changing self-hosted runner to the GitHub heavy by
[@aleksuss]. ([#881])
- Removed a logic of fee calculation in the eth-connector by
[@karim-en]. ([#882])
- Version of the rust nightly was updated to 2023-12-15 by
[@RomanHodulak]. ([#885])

[#881]: #881
[#882]: #882
[#883]: #883
[#885]: #885
[#888]: #888
[#889]: #889

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Guido Vranken <guidovranken@users.noreply.github.com>
Co-authored-by: Karim <karim@aurora.dev>
Co-authored-by: Roman Hodulák <roman.hodulak@aurora.dev>
Co-authored-by: Michael Birch <birchmd8@gmail.com>
Co-authored-by: Michael Birch <michael.birch@aurora.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksuss aleksuss aleksuss approved these changes

@mrLSD mrLSD mrLSD approved these changes

@birchmd birchmd birchmd approved these changes

@raventid raventid Awaiting requested review from raventid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RomanHodulak @mrLSD @aleksuss @birchmd