fix: do not require running contract in ft_resolve_transfer #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Feb 21, 2024
karim-en
approved these changes
Feb 21, 2024
mrLSD
approved these changes
Mar 2, 2024
aleksuss
added a commit
that referenced
this pull request
Mar 27, 2024
## Description AuditOne has announced the [issue](AuditOneAuditReviews/AuroraEngine-Audit-Review#18) in terms of migrating data before splitting the etc-connector logic. ## Performance / NEAR gas cost considerations No changes in performance. ## Testing The test for that doesn't look trivial.
Merged
aleksuss
added a commit
that referenced
this pull request
Mar 27, 2024
### Additions - Added a new view transaction `ft_balances_of` for getting balances for multiple accounts by [@karim-en]. ([#905]) ### Changes - The `ft_resolve_transfer` callback doesn't require running the contract to finish the `ft_transfer_call` correctly by [@aleksuss]. ([#906]) - Borsh has been bumped to 1.3 what allows to get rid of additional feature `borsh-compat` by [@aleksuss]. ([#907]) - The `ExecutionProfile` has been extended with logs for tests by [@mrLSD]. ([#910]) - The interface of the engine standalone storage has been extended with a couple of methods for allowing set/get arbitrary data outside the crate by [@aleksuss]. ([#913]) ### Fixes - Minor improvements and fixes by [@raventid]. ([#916]) [#905]: #905 [#906]: #906 [#907]: #907 [#910]: #910 [#913]: #913 [#916]: #916 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Karim <karim@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Julian Pokrovsky <raventid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AuditOne has announced the issue in terms of migrating data before splitting the etc-connector logic.
Performance / NEAR gas cost considerations
No changes in performance.
Testing
The test for that doesn't look trivial.