Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust scripts to work with Aurora. Add more util scripts. README improvements. #17

Merged
merged 9 commits into from May 17, 2021

Conversation

sept-en
Copy link
Contributor

@sept-en sept-en commented May 12, 2021

The scripts are compatible with this Aurora version deployed on the testnet.

Also addressed step-by-step guide comments by @joshuajbouw (thanks for pointing them out!)

* Fix some script usage bugs.
* Minor improvements.
* Change british->american spelling.
* Update README.
* Near withdraw to ETH script: fix to use the new args format and
  verify for edge cases.
* Other minor improvements.
* Minor refactoring.
@sept-en
Copy link
Contributor Author

sept-en commented May 12, 2021

NB: hardhat-related CI error is fixed in #16

Copy link
Contributor

@mfornet mfornet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I didn't tried the new guide myself, it would be really helpful to have a test that exercise this guide, and check it works as expected.

@sept-en sept-en merged commit 991403d into master May 17, 2021
@sept-en sept-en deleted the guide-and-script-fixes branch May 31, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants