Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix: switch wallet from unsuported network #206

Merged
merged 2 commits into from Apr 13, 2021
Merged

Conversation

paouvrard
Copy link
Member

Prevents the user from being stuck if the walletconnect connection
is lost and the network cannot be changed from mobile wallet, or if
mobile wallet doesn't support network change functionality.
image

@paouvrard paouvrard requested a review from chadoh as a code owner April 12, 2021 12:29
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; one small nit but otherwise seems good to go.

Should also probably center that button. Did we get design input from @corwinharrell ?

src/js/authEthereum.js Outdated Show resolved Hide resolved
@heycorwin
Copy link

What exactly is the result of clicking this button?

@paouvrard
Copy link
Member Author

@corwinharrell The "switch wallet" button will disconnect the ethereum wallet and open the ethereum login modal to choose from metamask and walletconnect.
Similar to this functionality you might have seen in other dapps:
image
Except in out case the text is different and we don't want the ability to access the UI without the correct network so no "Dismiss" and no modal closing functionality
We need this otherwise a user connected via walletconnect may get stuck with no way of changing wallet: they would need to go to local storage and delete the walletconnect connection.

Prevents the user from being stuck if the walletconnect connection
is lost and the network cannot be changed from mobile wallet, or if
mobile wallet doesn't support network change functionality.
@paouvrard paouvrard merged commit 39ade05 into master Apr 13, 2021
@chadoh
Copy link
Contributor

chadoh commented Apr 13, 2021

🎉 This PR is included in version 3.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikedotexe mikedotexe deleted the fix_unsuported_network branch April 15, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants