Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pip_deps to au_pip_deps #214

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

philsc
Copy link
Contributor

@philsc philsc commented Dec 21, 2023

I was experimenting with importing au, but ran into a conflict with
rules_docker's pip_deps repository. This patch fixes the conflict by
switching to a more unique name.

Another solution is to switch to bzlmod completely, but that's more
work.

I was experimenting with importing au, but ran into a conflict with
rules_docker's `pip_deps` repository. This patch fixes the conflict by
switching to a more unique name.

Another solution is to switch to bzlmod completely, but that's more
work.
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chiphogg chiphogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

Also, you missed the 0.3.4 release by mere hours. 😅 Oh well!

@chiphogg chiphogg merged commit 4ab84ce into aurora-opensource:main Dec 21, 2023
10 checks passed
@philsc philsc deleted the rename-pip-deps branch December 21, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants