Migrate to new home for LLVM toolchain #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM toolchain graduated from `grailbio/bazel-toolchain` to `bazel-contrib/toolchains_llvm`. Good for them! Unfortunately, that broke everyone's build who was using a `sha256` checksum, because GitHub does not guarantee SHA stability for automatically generated artifacts. (Remember when they [broke the world] in January 2023?) We need to upgrade to the new repo location, which means changing the SHA. We would not like to be forced to do this again, so we'll want to link to a concrete artifact, not an auto-generated one. This means moving from a particular commit hash to a named release, because the `.tar.gz` file is attached to that release. So we pick the latest one. I followed and adapted the [0.10.3 instructions], using the "not `bzlmod`" section. I also grepped the repo for `grailbio`, and updated a URL in some comments. (I verified that the new URL gives the same contents as the old one.) We hope and expect that this will unbreak our remote builds. [broke the world]: https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/ [0.10.3 instructions]: https://github.com/bazel-contrib/toolchains_llvm/releases/tag/0.10.3
geoffviola
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM toolchain graduated from
grailbio/bazel-toolchaintobazel-contrib/toolchains_llvm. Good for them! Unfortunately, thatbroke everyone's build who was using a
sha256checksum, because GitHubdoes not guarantee SHA stability for automatically generated artifacts.
(Remember when they broke the world in January 2023?)
We need to upgrade to the new repo location, which means changing the
SHA. We would not like to be forced to do this again, so we'll want to
link to a concrete artifact, not an auto-generated one. This means
moving from a particular commit hash to a named release, because the
.tar.gzfile is attached to that release. So we pick the latest one.I followed and adapted the 0.10.3 instructions, using the "not
bzlmod" section. I also grepped the repo forgrailbio, and updateda URL in some comments. (I verified that the new URL gives the same
contents as the old one.)
But wait, there's more! The
aspect-build/gcc-toolchainrepo alsomigrated to a new home! Now it lives with a particular individual
called
f0rmiga, instead of theaspect-buildbazel organization. Wecan't land code until we unbreak all of the builds, so we need to fix
that in the same PR. Here, I don't want to migrate to a new release,
because (a) we have a patch on top of the specific commit that we had
been using, and (b) they don't even upload archive files for their
releases.
Fixes #224.