Delete ForbidsComposingWith mixin
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes problems with Apple Clang version 9, apparently. I think this compiler technically falls outside of our support window. However, an actual user is having issues with it, and I think `ForbidsComposingWith` is adding only very marginal value anyway. I tried deleting it and the error messages became a couple of lines shorter, although perhaps less direct (no more reference to "explicitly deleted"). Amusingly, I'm keeping the unit test for it around, because it's one of those unfortunate "uncomment to test" deals, and the tests _will_ still pass. (We'll get compiler errors for doing unsupported operations.)
chiphogg
added
the
release notes: 🐛 lib (bugfix)
geoffviola
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes problems with Apple Clang version 9, apparently. I think this
compiler technically falls outside of our support window. However, an
actual user is having issues with it, and I think
ForbidsComposingWithis adding only very marginal value anyway. I tried deleting it and the
error messages became a couple of lines shorter, although perhaps less
direct (no more reference to "explicitly deleted").
Amusingly, I'm keeping the unit test for it around, because it's one of
those unfortunate "uncomment to test" deals, and the tests will still
pass. (We'll get compiler errors for doing unsupported operations.)
Fixes #226.