Explicitly specify QuantityPoint calc type
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to carry out our intermediate computations in the common type of the old and new rep, generally. However, we already know from #222 that if the new rep is a signed integer, and the old rep is unsigned, we need to be careful to use a signed type for intermediate computations. To preserve this behaviour but restore correct behavoiur for other cases (namely, #233), we add a new type trait for this intermediate type. It basically boils down to the common type, but with an explicit carve-out to keep #222 fixed. We explicitly cast both participants to this new type-for-intermediate-computations, and then cast to the destination rep at the end. Fixes #233.
chiphogg
added
the
release notes: 🐛 lib (bugfix)
geoffviola
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to carry out our intermediate computations in the common type of
the old and new rep, generally. However, we already know from #222 that
if the new rep is a signed integer, and the old rep is unsigned, we need
to be careful to use a signed type for intermediate computations.
To preserve this behaviour but restore correct behavoiur for other cases
(namely, #233), we add a new type trait for this intermediate type. It
basically boils down to the common type, but with an explicit carve-out
to keep #222 fixed. We explicitly cast both participants to this new
type-for-intermediate-computations, and then cast to the destination rep
at the end.
Compile time tests showed no discernible impact at all. This change has
also passed all Aurora-internal builds.
Fixes #233.