Support QuantityPoint in rounding functions
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the `round`, `floor`, and `ceil` families. There's more subtlety here than for `Quantity`, because we can have additive offsets. However, since these functions all aim to behave like the standard library, and the standard library always uses floating point, then it's actually quite simple. The way we handle rounding a quantity point in different units than it's stored is to first perform the conversion, then do the rounding. As with quantities, we use `RoundingRep` to make sure we're using a sane floating point type to perform the conversion. Includes a bunch of new test cases, and doc updates.
chiphogg
added
the
release notes: ✨ lib (enhancement)
geoffviola
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the
round,floor, andceilfamilies.There's more subtlety here than for
Quantity, because we can haveadditive offsets. However, since these functions all aim to behave like
the standard library, and the standard library always uses floating
point, then it's actually quite simple. The way we handle rounding a
quantity point in different units than it's stored is to first perform
the conversion, then do the rounding. As with quantities, we use
RoundingRepto make sure we're using a sane floating point type toperform the conversion.
Includes a bunch of new test cases, and doc updates.
Fixes #221.