Add basic CI job that runs CMake builds #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we simply run "the default CMake generator on the latest Ubuntu". Later on, if we tighten up our notion of "supported CMake configurations", we can add more options here.
|
FYI @timhirsh, we'll need a security review on jwlawson/actions-setup-cmake@802fa1a. Assuming it passes, we can add it to the allowlist in the repo settings, and after that, the job should run remotely. (I already ran it locally using nektos/act, so I know it works.) |
|
Alternatively, perhaps we should consider batching the security reviews (see #260). Our version of |
timhirsh
approved these changes
Jul 10, 2024
Co-authored-by: Tim Hirsh <timhirsh@users.noreply.github.com>
chiphogg
added
the
release notes: ⚙️ repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we simply run "the default CMake generator on the latest
Ubuntu". Later on, if we tighten up our notion of "supported CMake
configurations", we can add more options here.
Helps #215.