Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lane Layer highPrecisionDash doesn't work when segment length is less than dash. #437

Open
jcready opened this issue Apr 14, 2020 · 1 comment
Open

Lane Layer highPrecisionDash doesn't work when segment length is less than dash. #437

jcready opened this issue Apr 14, 2020 · 1 comment
Assignees
@twojtasz

Comments

@jcready
Copy link

jcready commented Apr 14, 2020

Enabling highPrecisionDash in the LaneLayer doesn't appear to handle segments which are shorter than the dash. The result is that no gaps are visible and a lane marker that should appear as dashed instead appears as solid.

image
@twojtasz
Copy link
Contributor

I have a reproducible test case locally now. Investigating the fix

twojtasz added a commit that referenced this issue May 18, 2020
@twojtasz
BUG: #437
e74a806
@twojtasz twojtasz self-assigned this Jun 16, 2020
jcready added a commit that referenced this issue Aug 29, 2020
@jcready
Fix #437 by replacing mix() with > 0.0 check
3a4d920 
For reasons beyond my understanding, the `mix()` function will not work
in this situation so instead replace them with ternary `> 0.0` checks.
@jcready jcready mentioned this issue Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twojtasz twojtasz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #437 by replacing mix() with > 0.0 check aurora-opensource/streetscape.gl
2 participants
@jcready @twojtasz