Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema change remove "position" as required field for images #458

Merged
merged 2 commits into from May 24, 2019

Conversation

twojtasz
Copy link
Contributor

No description provided.

@twojtasz twojtasz requested a review from jlisee May 20, 2019 19:48
@jlisee
Copy link
Contributor

jlisee commented May 23, 2019

Would be nifty to have a test example of an image with the minimal required fields so this does not regress.

@twojtasz twojtasz force-pushed the tpw/remove-pos-from-image-required branch from f9c56e8 to 3b4d4c0 Compare May 24, 2019 17:49
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.013% when pulling 3b4d4c0 on tpw/remove-pos-from-image-required into ed0ba18 on master.

@twojtasz twojtasz merged commit 51e6c9f into master May 24, 2019
@twojtasz twojtasz deleted the tpw/remove-pos-from-image-required branch September 5, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants