This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Disable pauses for auto pause enabled updates #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IT Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
ridv
reviewed
May 20, 2021
| .getInstructions() | ||
| .getSettings() | ||
| .getUpdateStrategy()); | ||
| if (isAutoPauseEnabled && instancesSeen.containsKey(key)) { |
There was a problem hiding this comment.
If we check if the instancesSeen contains the key, we can know the update started allowing us to pause for a brief time before the update starts if we do this check. It's probably overkill to do that in this case. I think in this case we can just check to see if it's auto pause enabled by itself.
There was a problem hiding this comment.
Yeah on second look it seems redundant. Fixed.
Signed-off-by: Abdul Qadeer <quadeer.leo@gmail.com>
ridv
pushed a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IT
Signed-off-by: Abdul Qadeer aqadeer@paypal.com
Description:
This PR prevents pauses on auto pause enabled job updates.
Testing Done:
Ran UTs - all passed
E2E tests (failures unrelated to this commit)