This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
[httpofferset] put the bad offers to the bottom of the list #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove Origin/http offer set perf improve
fetch from upstream - eom
|
@zorro786 please help reviewing this PR. |
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
biprade
reviewed
Oct 21, 2021
Co-authored-by: Bipra De <bipra.de@gmail.com>
…pl.java Co-authored-by: Bipra De <bipra.de@gmail.com>
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
biprade
reviewed
Oct 21, 2021
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetModule.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Bipra De <bipra.de@gmail.com>
biprade
approved these changes
Oct 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To avoid tasks landing on some bad nodes, we can put the nodes in the bottom of the offerset.
One of the usecases is there are too many tasks starting on the same node. This node may lead to overload during this time.
One of the issues we encountered is docker hangs up on these nodes.
Testing Done:
Unit tests
container based cluster tests