Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version_date should probably be the same as date of release #62

Closed
aslakr opened this issue Jun 29, 2017 · 2 comments
Closed

version_date should probably be the same as date of release #62

aslakr opened this issue Jun 29, 2017 · 2 comments
Labels
bug

Comments

@aslakr
Copy link

aslakr commented Jun 29, 2017

This https://github.com/aurora/rmate/blob/v0.9.9/rmate#L37 now says:

version="0.9.9"
version_date="2017-04-06"

I suppose it should be:

version="0.9.9"
version_date="2017-06-27"

or something similar.
@aurora
Copy link
Owner

aurora commented Jun 29, 2017

Yep, you are right -- i forgot to bump the date before tagging :-( ... but maybe it's time to bump to version 1.0.0 anyway ... :-)

@aurora
Copy link
Owner

aurora commented Jun 29, 2017

Fixed!

@aurora aurora closed this as completed Jun 29, 2017
@aurora aurora added the bug label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakr @aurora