Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for connecting via UNIX socket #66

Open
aurora opened this issue Jan 10, 2018 · 6 comments
Open

add support for connecting via UNIX socket #66

aurora opened this issue Jan 10, 2018 · 6 comments
Labels

Comments

@aurora
Copy link
Owner

aurora commented Jan 10, 2018

See #63 for details. This get's implemented by supporting a generic proxy-command that can be optionally specified as command-line argument or configured in the settings file.

@aurora aurora added the feature label Jan 10, 2018
@aurora
Copy link
Owner Author

aurora commented Jan 10, 2018

@jordemort is it ok to bother you with more questions on this? :-) First of all, i would like to add your little perl proxy to this repository, is it ok to add a GPL-3 license header (same license as rmate?). If yes, i would add the following to the perl proxy script:

#
# (c) copyright 2017-2018 Jordan Webb
# 
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
#

@jordemort
Copy link

Yes, that's fine with me

@hadisfr
Copy link
Contributor

hadisfr commented Aug 15, 2018

It seems there are still some undone works and unix-socket has not been merged to master till now.

What should be done to make it ready? 🤔 Is #63 (comment) done?

@aurora
Copy link
Owner Author

aurora commented Aug 16, 2018

I think it's still unfinished 😄 ... seems i really didn't have much time for this all, this year ... the plan was to make jordemort's patch a generic solution, where the proxy-command is configurable.

@aurora
Copy link
Owner Author

aurora commented Apr 8, 2019

first "generic-proxy command" commit: 85cecaf

@aurora
Copy link
Owner Author

aurora commented Apr 9, 2019

@jordemort i think i've got it working with the generic proxy-command, if you have time and would like to give it a try (the proxy-command branch). I am a little unhappy about my config-parser, because it would be more logic to put the proxy-command in quotes, so i have to probably improve the config-parser, next ...

@hadisfr you've updated the README in the past with information regarding sublime-text - i've already added documentation regarding this new feature to the README, but i am only familiar with TextMate. Would you be willing to give the proxy-command a try and updated the README for sublime-text, if necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants