Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing async #212

Merged
merged 48 commits into from
Jul 12, 2024
Merged

Increasing async #212

merged 48 commits into from
Jul 12, 2024

Conversation

phyzical
Copy link
Contributor

@phyzical phyzical commented Jul 10, 2024

Atm we are working around the fact that we cant seem to reuse the pushed images in ghcr by rebuilding via cache, takes about a minute but would proably be close to that to downlaod anyway? docker/build-push-action#1178 asking if theres something silly ive done
In anycase we will proably need to solve this in part 2 where we try to resuse the ghcr images for things like image scan publish app ect, so once tis solved the pipeline will slim down a fair bit

  • used composite actions to simplify common tasks between jobs
  • replaced native buildx with build push action
  • increased caching
  • runs commands async now so a worker per command
  • image scans and lints are async run on prod image
  • removed the async bash commands as we just dont need this workaround anymore

@phyzical phyzical changed the title Feature/moving ro more async Increasing async Jul 10, 2024
Copy link
Contributor

@waldofouche waldofouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GL - looks like quite an improvement

@phyzical phyzical merged commit 2ac525f into main Jul 12, 2024
@phyzical phyzical deleted the feature/moving-ro-more-async branch July 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants