Add extra host to start command (flyteorg#369)

* Add extra host to start command Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Make generate Signed-off-by: Kevin Su <pingsutw@apache.org> * update Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org>
austin362667 · May 7, 2024 · d528af1 · d528af1
1 parent e68672b
commit d528af1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/flytectl/pkg/docker/docker_util.go b/flytectl/pkg/docker/docker_util.go
@@ -47,6 +47,7 @@ var (
 	}
 	StdWriterPrefixLen = 8
 	StartingBufLen     = 32*1024 + StdWriterPrefixLen + 1
+	ExtraHosts         = []string{"host.docker.internal:127.0.0.1"}
 )
 
 // GetDockerClient will returns the docker client
@@ -237,6 +238,7 @@ func StartContainer(ctx context.Context, cli Docker, volumes []mount.Mount, expo
 		Mounts:       volumes,
 		PortBindings: portBindings,
 		Privileged:   true,
+		ExtraHosts:   ExtraHosts, // add it because linux machine doesn't have this host name by default
 	}, nil,
 		nil, name)
 

diff --git a/flytectl/pkg/docker/docker_util_test.go b/flytectl/pkg/docker/docker_util_test.go
@@ -156,6 +156,7 @@ func TestStartContainer(t *testing.T) {
 			Mounts:       Volumes,
 			PortBindings: p2,
 			Privileged:   true,
+			ExtraHosts:   ExtraHosts,
 		}, nil, nil, mock.Anything).Return(container.ContainerCreateCreatedBody{
 			ID: "Hello",
 		}, nil)
@@ -185,6 +186,7 @@ func TestStartContainer(t *testing.T) {
 			Mounts:       Volumes,
 			PortBindings: p2,
 			Privileged:   true,
+			ExtraHosts:   ExtraHosts,
 		}, nil, nil, mock.Anything).Return(container.ContainerCreateCreatedBody{
 			ID: "Hello",
 		}, nil)
@@ -211,6 +213,7 @@ func TestStartContainer(t *testing.T) {
 			Mounts:       Volumes,
 			PortBindings: p2,
 			Privileged:   true,
+			ExtraHosts:   ExtraHosts,
 		}, nil, nil, mock.Anything).Return(container.ContainerCreateCreatedBody{
 			ID: "",
 		}, fmt.Errorf("error"))
@@ -236,6 +239,7 @@ func TestStartContainer(t *testing.T) {
 			Mounts:       Volumes,
 			PortBindings: p2,
 			Privileged:   true,
+			ExtraHosts:   ExtraHosts,
 		}, nil, nil, mock.Anything).Return(container.ContainerCreateCreatedBody{
 			ID: "Hello",
 		}, nil)