Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRQA-87412, LRQA-87463 | master #329

Closed

Conversation

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@austinchiang
Copy link
Owner

@patriciajeanperez
Some notes:

  • Please make sure to run poshi-validation before submitting; it caught some things
  • DMDocument#sharePG can be broken down into smaller macros, but we can deal with that after this pull is merged

@austinchiang
Copy link
Owner

Pushed to BChan.
brianchandotcom#65606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants