Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nix to fork the process when launching the daemon #319

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Use nix to fork the process when launching the daemon #319

merged 1 commit into from
Jan 21, 2021

Conversation

austinjones
Copy link
Owner

@austinjones austinjones commented Jan 21, 2021 •
edited
Loading

This resolves #313, by forking the process when launching the daemon. This prevents the daemon from being reaped if:

  • The tab command was launched by a parent process.
  • The tab command exited.
  • The parent called std::process::Child::try_wait on the tab command handle.

@austinjones austinjones linked an issue Jan 21, 2021 that may be closed by this pull request
tab terminates the daemon when reconnecting to active sessions #313
Closed
@austinjones austinjones merged commit 1db6a6c into main Jan 21, 2021
@austinjones austinjones deleted the austinjones-fork-daemon branch January 21, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tab terminates the daemon when reconnecting to active sessions
1 participant
@austinjones