Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

adding an environment varible to disable pull requests #6

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Apr 21, 2021

This is a first shot at adding a boolean so the maintainer can manage their own decision to commit / pull request. Binoc can just assume that the latest pull of main is appropriate for making changes to.

Signed-off-by: vsoch vsoch@users.noreply.github.com

…anches

This will allow a maintainer to manage their own update logic

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Contributor Author

vsoch commented Apr 21, 2021

It seemed to work!

singularityhub/singularity-hpc#318

I'm going to merge the CI file into shpc for this branch, and test once again tomorrow with the last change that should remove the 5 second pauses (and I hope still work and run much faster!) I'll ping again here, report on how long it took, and update the PR to use the binoc container image and then if you want to review and we can discuss improvements we can do it after that. I think this could work!

@vsoch
Copy link
Contributor Author

vsoch commented Apr 21, 2021

Quick update - it worked great! 30 minutes down from 1 hour 20, and there is only one issue with the Kibana container, the version seems to be downgraded from what it was previously: https://github.com/singularityhub/singularity-hpc/pull/319/files#diff-f4fb54b9e9a19d6a9e8420c0cd084532d6111b26ef56fecbb0684831643e0e78R7. I think that's the only issue I see.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Copy link
Contributor

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of comments which I think we've already discussed I just thought I'd write them down before I forgot.

README.md Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@alecbcs
Copy link
Contributor

alecbcs commented Apr 22, 2021

Looks good to me!

@alecbcs alecbcs merged commit 57a169a into main Apr 22, 2021
@alecbcs alecbcs deleted the add/no-pr-option branch April 22, 2021 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants