Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for 'Class:method' in favour of ['Class', 'method'] #34

Closed
6 tasks done
anlutro opened this issue Oct 9, 2014 · 0 comments
Closed
6 tasks done
Labels
code quality enhancement New feature or request
Milestone

Comments

@anlutro
Copy link
Contributor

anlutro commented Oct 9, 2014

Stays more consistent with PHP's syntax - [$obj, method] can be passed to call_user_func for example, whereas Class:method is purely made up by me.

In modern PHP versions it's also easier and looks cleaner to do [Class::class, 'method'] than Class::class.':method'.

  • Add support everywhere for ['Class', 'method'] in 0.6.
  • Look into deprecating 'Class:method' in 0.7.

Places to add:

  • Route callables, filters, responders
  • Container invoke and define factory
  • Event listeners

Places to remove 'Class:method' syntax:

  • Route callables, filters, responders
  • Container invoke and define factory
  • Event listeners
@anlutro anlutro modified the milestones: 0.6, 0.7 Oct 10, 2014
@anlutro anlutro changed the title Add support for ['Class', 'method'] over 'Class:method' Remove support for 'Class:method' in favour of ['Class', 'method'] Oct 16, 2014
@anlutro anlutro added enhancement New feature or request code quality labels Oct 16, 2014
@anlutro anlutro closed this as completed Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant