Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoggedInOutlet.ts #30

Closed
wants to merge 1 commit into from
Closed

Conversation

tomteman
Copy link

@tomteman tomteman commented Aug 2, 2015

Since commit a9a552c112da1397a0122acdbecbd52bc88e1906 to angular2 (angular/angular@a9a552c), 'activate' became private and 'commit' should be used instead

Since commit a9a552c112da1397a0122acdbecbd52bc88e1906 to angular2 (angular/angular@a9a552c), 'activate' became private and 'commit' should be used instead
@valorkin valorkin mentioned this pull request Oct 19, 2015
@ocombe
Copy link

ocombe commented Jan 1, 2016

It's not private (anymore?), maybe they did revert the change ?
https://github.com/angular/angular/blob/2.0.0-beta.0/modules/angular2/src/router/router_outlet.ts#L54

You should close this PR :)

@chenkie chenkie closed this Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants