Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random-quote occasionally returns empty string as a quote #22

Closed
kmaida opened this issue Sep 16, 2016 · 0 comments
Closed

random-quote occasionally returns empty string as a quote #22

kmaida opened this issue Sep 16, 2016 · 0 comments

Comments

@kmaida
Copy link
Contributor

kmaida commented Sep 16, 2016 •
edited

Currently, the API can occasionally return empty when fetching quotes. This is due to zero-indexing when selecting from the quotes array and the use of length to get the quote position. The way it's randomizing, it can currently try to return a quote at one position after the last quote.

A fix is forthcoming shortly.
diegopoza added a commit that referenced this issue Sep 16, 2016
@diegopoza
Merge pull request #23 from kmaida/master
8a3e52e 
FIX #22 - now always return a quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmaida