Merge pull request #13 from zxan1285/storage-type

Storage type option
auth0-extensions · Oct 19, 2018 · c308150 · c308150
2 parents cdaec9a + 45b0780
commit c308150
Show file tree

Hide file tree

Showing 2 changed files with 79 additions and 3 deletions.
diff --git a/src/routes/dashboardAdmins.js b/src/routes/dashboardAdmins.js
@@ -59,10 +59,15 @@ module.exports = function(options) {
     throw new tools.ArgumentError('The provided client name is invalid: ' + options.clientName);
   }
 
+  if (typeof options.storageType !== 'undefined' && options.storageType !== 'sessionStorage' && options.storageType !== 'localStorage') {
+    throw new tools.ArgumentError('The storageType must be either "sessionStorage" or "localStorage". Incorrect storageType: ' + options.storageType);
+  }
+
   const stateKey = options.stateKey || 'state';
   const nonceKey = options.nonceKey || 'nonce';
   const urlPrefix = options.urlPrefix || '';
-  const sessionStorageKey = options.sessionStorageKey || 'apiToken';
+  const storageType = options.storageType || 'sessionStorage';
+  const storageKey = options.storageKey || options.sessionStorageKey || 'apiToken';
 
   const router = express.Router();
   router.get(urlPrefix + '/login', function(req, res) {
@@ -121,7 +126,7 @@ module.exports = function(options) {
         res.status(200).send('<html>' +
           '<head>' +
           '<script type="text/javascript">' +
-          'sessionStorage.setItem("' + sessionStorageKey + '", "' + token + '");' +
+          storageType + '.setItem("' + storageKey + '", "' + token + '");' +
           'window.location.href = "' + urlHelpers.getBaseUrl(req) + '";' +
           '</script>' +
           '</head>' +
@@ -142,7 +147,7 @@ module.exports = function(options) {
       '<html>' +
       '<head>' +
       '<script type="text/javascript">' +
-      'sessionStorage.removeItem("' + sessionStorageKey + '");' +
+      storageType + '.removeItem("' + storageKey + '");' +
       'window.location.href = "https://' + options.rta + '/v2/logout/?returnTo=' + encodedBaseUrl + '&client_id=' + encodedBaseUrl + '";' +
       '</script>' +
       '</head>' +

diff --git a/tests/routes/dashboardAdmins.js b/tests/routes/dashboardAdmins.js
@@ -138,6 +138,24 @@ tape('dashboardAdmins should throw error if options.clientName is empty', functi
   }
 });
 
+tape('dashboardAdmins should throw error if options.storageType is incorrect', function(t) {
+  try {
+    dashboardAdmins({
+      secret: 'abc',
+      audience: 'urn:api',
+      rta: 'auth0.auth0.com',
+      domain: 'test.auth0.com',
+      baseUrl: 'http://api',
+      storageType: 'storageType',
+      clientName: 'Some Client'
+    });
+  } catch (e) {
+    t.ok(e);
+    t.equal(e.name, 'ArgumentError');
+    t.end();
+  }
+});
+
 tape('dashboardAdmins should redirect to auth0 on /login', function(t) {
   const mw = dashboardAdmins({
     secret: 'abc',
@@ -318,3 +336,56 @@ tape('dashboardAdmins should return 200 if everything is ok', function(t) {
   mw(req, res);
 });
 
+tape('dashboardAdmins should work with localStorage', function(t) {
+  const mw = dashboardAdmins({
+    secret: 'abc',
+    audience: 'urn:api',
+    rta: 'test.auth0.com',
+    domain: 'test.auth0.com',
+    baseUrl: 'https://test.auth0.com/api/v2/',
+    storageType: 'localStorage',
+    clientName: 'Some Client'
+  });
+
+  tokens.wellKnownEndpoint('test.auth0.com', certs.bar.cert, 'key2');
+  const token = tokens.sign(certs.bar.private, 'key2', {
+    iss: 'https://test.auth0.com/',
+    sub: '1234567890',
+    aud: 'https://test.auth0.com/api/v2/',
+    azp: 'https://test.auth0.com/api/v2/',
+    name: 'John Doe',
+    admin: true,
+    nonce: 'nonce'
+  });
+
+  const req =
+    {
+      headers: {},
+      cookies: {
+        state: 'state',
+        nonce: 'nonce'
+      },
+      body: {
+        state: 'state',
+        id_token: token,
+        access_token: token
+      },
+      url: 'http://api/login/callback',
+      method: 'post'
+    };
+
+  const res = {
+    header: function() { },
+    status: function(status) {
+      return {
+        send: function(html) {
+          t.ok(html && html.indexOf('localStorage') > 0);
+          t.equal(status, 200);
+          t.end();
+        }
+      };
+    }
+  };
+
+  mw(req, res);
+});