Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1672] Update Asp.Net OWIN quickstart to use SystemWebCookieManager #29

Merged
merged 8 commits into from Jun 26, 2020

Conversation

stevehobbsdev
Copy link
Contributor

This PR upgrades the 01-Login sample - the other samples will be upgraded in separate PRs.

  • Upgrade Microsoft.Owin.Security.Cookies to 4.1.0, which will allow them to set the SameSite property when configuring cookie authentication. The sample will set this to Lax as it doesn't need anything else, but the customer should consider whether other values are more appropriate for them.
  • Upgrade to .Net Framework 4.7.2 to enable SameSite support for SystemWebCookieManager (reasoning)
  • Add supporting cookie manager + samesite files to overcome issues with using System.Web cookies and OWIN cookies together

@stevehobbsdev stevehobbsdev added the review:medium Medium review label Jun 24, 2020
@stevehobbsdev stevehobbsdev requested a review from a team June 24, 2020 14:10
@stevehobbsdev
Copy link
Contributor Author

Previously approved here. Force merging to deal with Snyk issues.

@stevehobbsdev stevehobbsdev merged commit 4dd76ca into master Jun 26, 2020
@stevehobbsdev stevehobbsdev deleted the owin-cookie-samesite branch June 26, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant