Make expo use scheme #113
Merged
Make expo use scheme #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2023
Widcket
reviewed
Apr 4, 2023
Widcket
approved these changes
Apr 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this documentation change, we are making custom scheme mandatory. This is due to the reason that Expo uses the application ID or bundle identifier we use to as the scheme to open the application. This shows a popup when the login is done successfully and choosing the wrong option could break the application flow.
For this reason we have made custom scheme as mandatory for Expo application and added guidance on how to do it.
This will change in the next major where we will generate the scheme for callback URL with
auth0prefixed to the package name to avoid clash with ExpoReferences
Issues were raised because of this
auth0/react-native-auth0#582
auth0/react-native-auth0#606
PR in repo - auth0/react-native-auth0#610
PR in Docs - auth0/docs#10243