Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue2.0 deprecated lifecycle hook #17

Closed
marclave opened this issue Apr 12, 2017 · 1 comment
Closed

Vue2.0 deprecated lifecycle hook #17

marclave opened this issue Apr 12, 2017 · 1 comment

Comments

@marclave
Copy link

Noticed inside of package.json, Vue2.0 is being used. However, the lifecycle hook from 1.X to 2.X has changed Ready() to mounted()

https://vuejs.org/v2/guide/instance.html

https://github.com/auth0-samples/auth0-vue-samples/blob/master/01-Login/package.json#L20

In app.js you are using mounted() but the documentation on quickstart guide is not updated

@stevehobbsdev
Copy link
Contributor

stevehobbsdev commented Apr 17, 2019

Hey @marclave, the sample app has been updated since this issue was raised, and contains the correct lifecycle hooks.

I'll close this issue for now - thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants