-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Keyword Replacement Mapping Feature #42
Conversation
I've tested and everything appears to work well. I think we should wait and have Sara do a run-through as well just to be certain. Thanks Bobby! |
That works for me. I have not done the release prep yet. Maybe @kazemicode can do it once she has reviewed for the practice on releasing. |
@NotMyself Tested and can confirm the fixes for #45 works as expected. For #43, it only works as expected if there's already existing data in Regarding #44, I don't see any evidence of the shell script executing after creating one and adding the path to |
@kazemicode thanks for the review! While I was waiting for the first fix to get approved... I was implementing fixes for other things... So #43 should be working now and I am working on #44 right now. I'll let you know when they are ready. |
@jesposito @kazemicode all three fixes are now in. We have verified they work for us in our use case. Just need confirmation that we didn't break labs... and you all approve. Then we can ship a new version with killer new features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR addresses a number of feature requests for running samples in GitHub Codespaces and advanced configuration use cases.
Fixes #45
Fixes #44
Fixes #43
Testing
To test this change, you will need to run a lab in codespaces with a custom build of the extension.
...
menu and select Install from VSIXYou now have a custom install of the extension running in codespaces.
Default Keyword Replacement Mapping
Update the tenant.yml for the lab to include the keyword replacements for
AUTH0_DOMAIN
andCODESPACE_NAME
. Sign in to a tenant and click the configure button when prompted.The deploy should be successful and you should see the appropriate values in your tenant and associated .env files.
Post Configuration Script
Update the environment.json for the lab to include a reference to a shell script. Create the shell script and echo out the values for
AUTH0_DOMAIN
andAUTH0_TOKEN
.Run the configure command and verify values are printed to console output.
Multiple Writes to Same .env File
Update the environment.josn for the lab to write two or more clients to the same directory.
Run the configure command and verify that all values are written to the .env file with no duplication.
Checklist
master