Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scope property to Credentials #120

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Jun 8, 2017

No description provided.

@cocojoe cocojoe requested a review from lbalmaceda June 9, 2017 08:54
@cocojoe
Copy link
Member Author

cocojoe commented Jun 9, 2017

@lbalmaceda See if the scope property doc makes sense

@cocojoe cocojoe added this to the v1-Next milestone Jun 9, 2017
@cocojoe cocojoe requested a review from hzalaz June 9, 2017 11:34
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok, my only doubt is if I as a dev would need the scope to be a String[] rather than just a String, for easy checking of granted scopes.

@hzalaz
Copy link
Member

hzalaz commented Jun 10, 2017

@lbalmaceda it will be [String] 😜 .

@cocojoe expanding what @lbalmaceda said we could have a method to help check that the returned scopes contains a list of scopes like

let requested = "openid profile email read:user post:ticket"
...
let missing: [String] = credentials.rejected(from: requested)

but it could be material of another PR so Android is in sync too

@cocojoe
Copy link
Member Author

cocojoe commented Jun 12, 2017

Agree a helper would be nice, as this has been approved already will merge and raise another PR.

@cocojoe cocojoe merged commit 2e1cdc4 into master Jun 12, 2017
@hzalaz hzalaz deleted the added-credentials-scopes branch June 12, 2017 13:29
@cocojoe cocojoe modified the milestones: 1.7.0, v1-Next Jun 26, 2017
@cocojoe cocojoe mentioned this pull request Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants