Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invalid_credentials check for /oauth/token #147

Merged
merged 3 commits into from
Sep 8, 2017

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Sep 7, 2017

No description provided.

lbalmaceda
lbalmaceda previously approved these changes Sep 7, 2017
@cocojoe cocojoe changed the title Added invalid credentials check for OIDC Added invalid_credentials check for /oauth/token Sep 7, 2017
(See if fixes codecov)
lbalmaceda
lbalmaceda previously approved these changes Sep 8, 2017
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced about changing the patch to 0, but if you say that it means "latest patch" then ok. I'm used to see "1.+" instead.

@cocojoe
Copy link
Member Author

cocojoe commented Sep 8, 2017

I changed it back, although it's fine, I dunno it just looks better with latest 😄

@cocojoe cocojoe merged commit f63ff21 into master Sep 8, 2017
@cocojoe cocojoe deleted the added-invalid-password branch September 8, 2017 14:17
@cocojoe cocojoe modified the milestones: v1-Next, 1.7.2 Sep 11, 2017
@cocojoe cocojoe mentioned this pull request Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants