Added SFAuthenticationSession support in iOS 11 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cocojoe
commented
Sep 19, 2017
•
cocojoe
commented
- Adding SFAuthenticationSession support for iOS 11 (Default behaviour for iOS 11 Devices)
- Added clearSession using SFAuthenticationSession - Requires registration of callback schema in logouts URL in dashboard. (Added to README)
Ensure all references to SafariWebAuth switch based upon iOS version Added backwards compatibility Xcode 8 Added pod exclusions Updated tests
cocojoe
force-pushed
the
added-sfauthenticationsession-pathway
branch
from
7c1e1f9
to
bd66a84
Compare
Added more Tests
Add Swift version check to Tests
cocojoe
force-pushed
the
added-sfauthenticationsession-pathway
branch
from
3b24357
to
895a23a
Compare
hzalaz
approved these changes
Oct 10, 2017
hzalaz
reviewed
Oct 10, 2017
| @@ -100,6 +101,11 @@ class SafariWebAuth: WebAuth { | |||
| return self | |||
| } | |||
|
|
|||
| func useLegacyAuthentication() -> Self { | |||
There was a problem hiding this comment.
Not a big fun but can't think of a better name 😄
There was a problem hiding this comment.
Naming is the hardest part of development 😆
hzalaz
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.