Fix Swift 4.1 Warning #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
force-pushed
the
updated-xcode-9.4
branch
from
bbe85ac
to
f019100
Compare
guykogus
previously approved these changes
Jul 24, 2018
|
Kind of strange 9.4.1 throws "Gem::FilePermissionError: You don't have write permissions for the" |
|
Could you use |
|
It should work anyway, feels more likely image is broken, will roll back to 9.4.0 |
|
@lbalmaceda ping |
lbalmaceda
approved these changes
Jul 24, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compiler warning if the project is compiled as 4.1.
flatMapis Swift 3.xcompactMapis only available in 4.1,flatMapwill produce a compiler warning in Swift 4.1The ! to ? came up in the original PR, although I think this was caused by another change in the original PR that I reverted. However, the style in this PR is more consistent with the rest of the spec.
The project should be 3.x, seems to have accidentally been update in the last PR, so coincidentally this fixes it.