Add Multiple Platform CI #242
Conversation
| @@ -9,7 +9,7 @@ platform :ios do | |||
| desc "Installs dependencies using Carthage" | |||
| lane :dependencies do |options| | |||
| action = options[:action] | |||
| carthage(use_binaries: false, command: action, cache_builds: true, platform: 'all') | |||
| carthage(use_binaries: false, command: action, cache_builds: true, platform: 'iOS') | |||
There was a problem hiding this comment.
what about macOS and tvOS? They get removed if you change this.
There was a problem hiding this comment.
Limiting build to the platform in question, otherwise it will build every platform even though it's only using 1. The previous option of 'all' was wrong. I
| - run: | | ||
| bash <(curl -s https://codecov.io/bash) -J 'Auth0' | ||
| bash <(curl -s https://codecov.io/bash) -J 'Auth0' |
There was a problem hiding this comment.
Should we also upload the coverage for the rest of the build variants? Why do you need to pass the package name?
There was a problem hiding this comment.
I've ran into issues in the past with multiple codecov, I don't think it understands what to do with it for example. MacOS doesn't have WebAuth so if that report is sent after the iOS one codecov will report lots of missing codecov.
.circleci/config.yml
Outdated
| @@ -1,18 +1,16 @@ | |||
| version: 2 | |||
| jobs: | |||
| build-and-test: | |||
| build-and-test-iOS-swift-4.2: | |||
There was a problem hiding this comment.
I'd rename it to something shorter. They are all builds running tests.
iOS-swift-4.2-buildbuild-iOS-swift-4.2
Update Code for 4.2