Rework errors handling #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.06%@@ master #26 diff @@
==========================================
Files 27 30 +3
Lines 913 894 -19
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 673 689 +16
+ Misses 240 205 -35
Partials 0 0
|
Now instead of an Enum, an ErrorType is supplied on each failure. The ErrorType could be either a OS error (e.g. Foundation errors) or Auth0 errors either returned by the API or it's components because a configuration issue.
Fix broken cancelled flow in webauth Extracted separated protocol for ErrorType -> NSError map
All errors listed are those that can be of interest to the end user.
hzalaz
force-pushed
the
feature-auth-error
branch
from
287f821
to
a1f1ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication & Management API errors are no longer an enum but an object to provide more flexibility.
Now all request yield
ErrorTypethat can beAuthenticationError|ManagementErroror a foundation error raised during the request.For web-based authentication, the enum
WebAuthErrorwas created with the only 3 possible errors caused by it: