Added support for iOS13 changes in ASWebAuthenticationSession #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cocojoe
changed the title
cocojoe
commented
Aug 17, 2019
| @@ -100,7 +100,9 @@ public struct Telemetry { | |||
| } | |||
|
|
|||
| static func swiftVersion() -> String { | |||
| #if swift(>=4.0) | |||
There was a problem hiding this comment.
Quick change to add support for 5.x logging and no you can't simply ask for the literal string version
cocojoe
commented
Aug 17, 2019
| @@ -236,7 +239,7 @@ class SafariWebAuth: WebAuth { | |||
| } | |||
|
|
|||
| private func generateDefaultState() -> String? { | |||
| var data = Data(count: 32) | |||
cocojoe
commented
Aug 17, 2019
| @@ -127,4 +135,13 @@ class SafariAuthenticationSession: AuthSession { | |||
| authSession = nil | |||
| } | |||
| } | |||
|
|
|||
| #if swift(>=5.1) | |||
There was a problem hiding this comment.
Basically asks is this Xcode 11 as the compiler is 5.1
cocojoe
commented
Aug 17, 2019
.circleci/config.yml
Outdated
| steps: | ||
| - run: | ||
| name: Set Ruby Version | ||
| command: echo "ruby-2.5" > ~/.ruby-version |
There was a problem hiding this comment.
Default ruby not working in this new image, this is the workaround.
cocojoe
commented
Aug 17, 2019
| @@ -1276,7 +1276,7 @@ | |||
| isa = PBXProject; | |||
There was a problem hiding this comment.
In general you can ignore these, it's just updating to latest version
damieng
reviewed
Aug 17, 2019
damieng
previously approved these changes
Aug 17, 2019
Update Example App Update Deps
Update Telemetry
cocojoe
force-pushed
the
added-ios13-webauth-compatibility
branch
from
3bd3729
to
baac5b1
Compare
Merged
sam-w
added a commit
to LoungeBuddy/Auth0.swift
that referenced
this pull request
Mar 11, 2020
…auth0#297)" This reverts commit 882c513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
iOS 13 Requires presentationContextProvider to be set in ASWebAuthenticationSession so the Browser can be displayed. Without this, the WebAuthentication flow will fail.
This PR adds default window for this so there is no breaking changing required for this to be set by the developer.
Notes:
Developers will need to update to this minor otherwise the previous version which will compile will have a run time issue due to the breaking change in iOS 13 behaviour. See References
References
#295
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist